On Fri, Jun 03, 2022 at 12:41:55AM +0000, Sean Christopherson wrote: > Rename 'struct vcpu' to 'struct kvm_vcpu' to align with 'struct kvm_vm' > in the selftest, and to give readers a hint that the struct is specific > to KVM. I'm not completely sold on this change. I don't mind that the selftest vcpu struct isn't named the same as the KVM vcpu struct, since they're different structs. I also don't mind avoiding 'kvm_' prefixes in "KVM selftests" (indeed I wonder if we really need the kvm_ prefix for the vm struct). If we do need prefixes for the kvm selftest framework code to avoid collisions with test code, then maybe we should invent something else, rather than use the somewhat ambiguous 'kvm', which could also collide with stuff in the kvm uapi. Thanks, drew
