On Wed, Jun 08, 2022, Vasant Karasulli wrote: > On Mi 06-04-22 01:22:55, Sean Christopherson wrote: > > > + if (ret) { > > > + kunit_info(test, "Could not register kretprobe. Skipping."); > > > + goto out; > > > + } > > > + > > > + test->priv = kunit_kzalloc(test, sizeof(u64), GFP_KERNEL); > > > > Allocating 8 bytes and storing the pointer an 8-byte field is rather pointless :-) > > > > Actually it's necessary to allocate memory to test->priv before using according to > https://www.kernel.org/doc/html/latest/dev-tools/kunit/tips.html If priv points at structure of some form, sure, but you're storing a simple value.