On Thu, 2022-06-02 at 19:56 +0530, Santosh Shukla wrote: > VNMI feature allows the hypervisor to inject NMI into the guest w/o > using Event injection mechanism, The benefit of using VNMI over the > event Injection that does not require tracking the Guest's NMI state and > intercepting the IRET for the NMI completion. VNMI achieves that by > exposing 3 capability bits in VMCB intr_cntrl which helps with > virtualizing NMI injection and NMI_Masking. > > The presence of this feature is indicated via the CPUID function > 0x8000000A_EDX[25]. > > Signed-off-by: Santosh Shukla <santosh.shukla@xxxxxxx> > --- > arch/x86/include/asm/cpufeatures.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index 393f2bbb5e3a..c8775b25856b 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -346,6 +346,7 @@ > #define X86_FEATURE_V_VMSAVE_VMLOAD (15*32+15) /* Virtual VMSAVE VMLOAD */ > #define X86_FEATURE_VGIF (15*32+16) /* Virtual GIF */ > #define X86_FEATURE_V_SPEC_CTRL (15*32+20) /* Virtual SPEC_CTRL */ > +#define X86_FEATURE_V_NMI (15*32+25) /* Virtual NMI */ > #define X86_FEATURE_SVME_ADDR_CHK (15*32+28) /* "" SVME addr check */ > > /* Intel-defined CPU features, CPUID level 0x00000007:0 (ECX), word 16 */ I also think that AMD should publish some sort of a 'future ISA' spec like Intel does, so that we could avoid mistakes in reviweing the code. Other than that: Reviewed-by: Maxim Levitsky <mlevitsk@xxxxxxxxxx> Best regards, Maxim Levitsky
