On Fr 08-04-22 15:44:26, Borislav Petkov wrote: > > Subject: Re: [PATCH v6 1/4] x86/tests: Add tests for AMD SEV-ES #VC handling > > > diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile > > index 6aef9ee28a39..69472a576909 100644 > > --- a/arch/x86/kernel/Makefile > > +++ b/arch/x86/kernel/Makefile > > @@ -24,6 +24,13 @@ CFLAGS_REMOVE_sev.o = -pg > > CFLAGS_REMOVE_cc_platform.o = -pg > > endif > > > > +# AMD_SEV_TEST_VC registers a kprobe by function name. IPA-SRA creates > > +# function copies and renames them to have an .isra suffix, which breaks kprobes' > > +# lookup. Build with -fno-ipa-sra for the test. > > +ifdef CONFIG_AMD_SEV_TEST_VC > > Why ifdef? > > I think you want this to be enabled unconditionally since the VC tests > select KRPOBES. > VC tests added in this patch series depend on the configuration option CONFIG_AMD_SEV_TEST_VC which in turn selects KPROBES. I think compiler flag -fno-ipa-sra wouldn't be necessary if configuration option CONFIG_AMD_SEV_TEST_VC is disabled. > > +CFLAGS_sev.o += -fno-ipa-sra > > +endif > > + > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette -- Vasant Karasulli Kernel generalist www.suse.com<http://www.suse.com> [https://www.suse.com/assets/img/social-platforms-suse-logo.png]<http://www.suse.com/> SUSE - Open Source Solutions for Enterprise Servers & Cloud<http://www.suse.com/> Modernize your infrastructure with SUSE Linux Enterprise servers, cloud technology for IaaS, and SUSE's software-defined storage. www.suse.com
