Re: [RFC PATCH v6 006/104] KVM: TDX: Detect CPU feature on kernel module initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2022-05-26 at 12:28 -0700, Isaku Yamahata wrote:
> +       if (!platform_has_tdx()) {
> +               if (__seamrr_enabled())
> +                       pr_warn("Cannot enable TDX with SEAMRR disabled\n");
> +               else
> +                       pr_warn("Cannot enable TDX on TDX disabled platform.\n");
> +               return -ENODEV;
> +       }

This is really overkill.  I cannot tell the difference between "SEAMRR disabled"
and "TDX disabled platform".

Btw, the v4 has removed __seamrr_enabled(), and there are other changes too. 
Could you rebase the KVM code to latest v4?

https://lore.kernel.org/lkml/cover.1654025430.git.kai.huang@xxxxxxxxx/

-- 
Thanks,
-Kai





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux