On Wed, Jun 1, 2022 at 1:43 PM Andrew Jones <drjones@xxxxxxxxxx> wrote:
> On Wed, Jun 01, 2022 at 01:09:13PM -0400, Dan Cross wrote:
> > Thanks. I think the easiest way to fix this is to plumb an
> > argument through to the linker that expands to `-m elf_i386`
> > on 32-bit, and possibly, `-m elf_x86_64` on 64-bit. The
> > architecture specific Makefiles set the `ldarch` variable,
> > and that doesn't seem used anywhere, but I see that's set
> > to match the string accepted by the linker scripts/objcopy,
> > not something acceptable to `-m`. However, one can add
> > something to `LDARGS`, but I see that that's set to include
> > the contents of CFLAGS, which means it includes flags
> > that are not directly consumable by the linker itself.
> >
> > I think the simplest way forward is to introduce a new
> > variable in x86/Makefile.i386 and x86/Makefile.x86_64 and
> > refer to that in x86/Makefile.common; possibly `LDEXTRA`?
>
> We do that for arm, but call that argument arch_LDFLAGS.
Ah cool; I see the pattern now. Okay, I've modified x86 to
follow ARM in this regard and tested locally.
> > I've got an updated patch here that does that, and it seems
> > to work (building under both illumos and arch locally), but
> > before I send up another patchset, let me know if that
> > sounds acceptable?
>
> It does to me.
>
> Thanks,
> drew
Great. Next patch rev inbound.
- Dan C.
