Re: [PATCH v10 15/19] KVM: s390: pv: asynchronous destroy for reboot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 30 May 2022 11:46:26 +0200
Nico Boehr <nrb@xxxxxxxxxxxxx> wrote:

> On Thu, 2022-04-14 at 10:03 +0200, Claudio Imbrenda wrote:
> [...]
> > diff --git a/arch/s390/kvm/pv.c b/arch/s390/kvm/pv.c
> > index b20f2cbd43d9..36bc107bbd7d 100644
> > --- a/arch/s390/kvm/pv.c
> > +++ b/arch/s390/kvm/pv.c  
> [...]
> > +/**
> > + * kvm_s390_pv_deinit_vm_async - Perform an asynchronous teardown of
> > a
> > + * protected VM.
> > + * @kvm the VM previously associated with the protected VM
> > + * @rc return value for the RC field of the UVCB
> > + * @rrc return value for the RRC field of the UVCB
> > + *
> > + * Tear down the protected VM that had previously been set aside
> > using
> > + * kvm_s390_pv_deinit_vm_async_prepare.
> > + *
> > + * Context: kvm->lock needs to be held  
> 
> ...and will be released...

no, I decided to refactor this so that the lock won't be held at
all when not needed (you'll see in the next respin), should be cleaner

> 
> > + *
> > + * Return: 0 in case of success, -EINVAL if no protected VM had been
> > + * prepared for asynchronous teardowm, -EIO in case of other errors.
> > + */
> > +int kvm_s390_pv_deinit_vm_async(struct kvm *kvm, u16 *rc, u16 *rrc)  
> 
> Do you also want to set rc and rrc as in kvm_s390_pv_deinit_vm_async_prepare()?

oh... no I don't

I should propagate the actual RC and RRC from the UVC, which I'm not
doing (will fix)




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux