Hi Sean, I love your patch! Yet something to improve: [auto build test ERROR on 90bde5bea810d766e7046bf5884f2ccf76dd78e9] url: https://github.com/intel-lab-lkp/linux/commits/Sean-Christopherson/KVM-x86-Emulator-_regs-fixes-and-cleanups/20220526-062734 base: 90bde5bea810d766e7046bf5884f2ccf76dd78e9 config: i386-debian-10.3-kselftests (https://download.01.org/0day-ci/archive/20220526/202205261040.m1luL6IW-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-1) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/a2e1bffa1b7c8179bed0c28ade24b1a73d7220de git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Sean-Christopherson/KVM-x86-Emulator-_regs-fixes-and-cleanups/20220526-062734 git checkout a2e1bffa1b7c8179bed0c28ade24b1a73d7220de # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from arch/x86/kvm/x86.h:9, from arch/x86/kvm/cpuid.h:5, from arch/x86/kvm/mmu.h:7, from arch/x86/kvm/x86.c:22: >> arch/x86/kvm/kvm_emulate.h:310:34: error: 'VCPU_REGS_R15' undeclared here (not in a function); did you mean 'VCPU_REGS_RIP'? 310 | #define NR_EMULATOR_GPRS (VCPU_REGS_R15 + 1) | ^~~~~~~~~~~~~ arch/x86/kvm/kvm_emulate.h:374:29: note: in expansion of macro 'NR_EMULATOR_GPRS' 374 | unsigned long _regs[NR_EMULATOR_GPRS]; | ^~~~~~~~~~~~~~~~ -- In file included from arch/x86/kvm/emulate.c:23: >> arch/x86/kvm/kvm_emulate.h:310:34: error: 'VCPU_REGS_R15' undeclared here (not in a function); did you mean 'VCPU_REGS_RIP'? 310 | #define NR_EMULATOR_GPRS (VCPU_REGS_R15 + 1) | ^~~~~~~~~~~~~ arch/x86/kvm/kvm_emulate.h:374:29: note: in expansion of macro 'NR_EMULATOR_GPRS' 374 | unsigned long _regs[NR_EMULATOR_GPRS]; | ^~~~~~~~~~~~~~~~ arch/x86/kvm/emulate.c: In function 'reg_write': arch/x86/kvm/emulate.c:268:1: error: control reaches end of non-void function [-Werror=return-type] 268 | } | ^ arch/x86/kvm/emulate.c: In function 'reg_read': arch/x86/kvm/emulate.c:258:1: error: control reaches end of non-void function [-Werror=return-type] 258 | } | ^ cc1: some warnings being treated as errors -- In file included from arch/x86/kvm/vmx/../x86.h:9, from arch/x86/kvm/vmx/../cpuid.h:5, from arch/x86/kvm/vmx/evmcs.c:7: >> arch/x86/kvm/vmx/../kvm_emulate.h:310:34: error: 'VCPU_REGS_R15' undeclared here (not in a function); did you mean 'VCPU_REGS_RIP'? 310 | #define NR_EMULATOR_GPRS (VCPU_REGS_R15 + 1) | ^~~~~~~~~~~~~ arch/x86/kvm/vmx/../kvm_emulate.h:374:29: note: in expansion of macro 'NR_EMULATOR_GPRS' 374 | unsigned long _regs[NR_EMULATOR_GPRS]; | ^~~~~~~~~~~~~~~~ vim +310 arch/x86/kvm/kvm_emulate.h 303 304 /* 305 * The emulator's _regs array tracks only the GPRs, i.e. excludes RIP. RIP is 306 * tracked/accessed via _eip, and except for RIP relative addressing, which 307 * also uses _eip, RIP cannot be a register operand nor can it be an operand in 308 * a ModRM or SIB byte. 309 */ > 310 #define NR_EMULATOR_GPRS (VCPU_REGS_R15 + 1) 311 -- 0-DAY CI Kernel Test Service https://01.org/lkp
