Re: [PATCH RESEND v12 00/17] KVM: x86/pmu: Add basic support to enable guest PEBS via DS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/25/22 09:56, Like Xu wrote:
Thanks for the clarification.

Some kvm x86 selftests have been failing due to this issue even after the last commit.

I blame myself for not passing the msr_info->host_initiated to the intel_is_valid_msr(), meanwhile I pondered further whether we should check only the MSR addrs range in the kvm_pmu_is_valid_msr() and apply this kind of sanity check in the pmu_set/get_msr().

Vitaly && Paolo, any preference to move forward ?

I'm not sure what I did wrong to not see the failure, so I'll fix it myself.

But from now on, I'll have a hard rule of no new processor features enabled without KVM unit tests or selftests. In fact, it would be nice if you wrote some for PEBS.

Paolo




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux