Re: [RFC PATCH v4 16/36] i386/tdvf: Introduce function to parse TDVF metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC PATCH v4 16/36] i386/tdvf: Introduce function to parse TDVF metadata
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Tue, 24 May 2022 09:02:58 +0200
Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>, Isaku Yamahata <isaku.yamahata@xxxxxxxxx>, isaku.yamahata@xxxxxxxxx, Daniel P . Berrangé <berrange@xxxxxxxxxx>, Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, "Michael S . Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Laszlo Ersek <lersek@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Connor Kuehl <ckuehl@xxxxxxxxxx>, erdemaktas@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, qemu-devel@xxxxxxxxxx, seanjc@xxxxxxxxxx
In-reply-to: <20220512031803.3315890-17-xiaoyao.li@intel.com>
References: <20220512031803.3315890-1-xiaoyao.li@intel.com> <20220512031803.3315890-17-xiaoyao.li@intel.com>

  Hi,

> +static int tdvf_parse_section_entry(const TdvfSectionEntry *src,
> +                                     TdxFirmwareEntry *entry)

> +    /* sanity check */

That is what the whole function is doing.  So rename it to
tdvf_check_section_entry to clarify that?

take care,
  Gerd

Follow-Ups:
- Re: [RFC PATCH v4 16/36] i386/tdvf: Introduce function to parse TDVF metadata
  - From: Xiaoyao Li

References:
- [RFC PATCH v4 00/36] TDX QEMU support
  - From: Xiaoyao Li
- [RFC PATCH v4 16/36] i386/tdvf: Introduce function to parse TDVF metadata
  - From: Xiaoyao Li

Prev by Date: Re: [PATCH] s390/uv_uapi: depend on CONFIG_S390
Next by Date: Re: [RFC PATCH v4 17/36] i386/tdx: Parse TDVF metadata for TDX VM
Previous by thread: [RFC PATCH v4 16/36] i386/tdvf: Introduce function to parse TDVF metadata
Next by thread: Re: [RFC PATCH v4 16/36] i386/tdvf: Introduce function to parse TDVF metadata
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]