RE: [PATCH] vfio/pci: Add driver_managed_dma to the new vfio_pci drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Sent: Friday, May 20, 2022 7:14 AM
> 
> When the iommu series adding driver_managed_dma was rebased it missed
> that
> new VFIO drivers were added and did not update them too.
> 
> Without this vfio will claim the groups are not viable.
> 
> Add driver_managed_dma to mlx5 and hisi.
> 
> Fixes: 70693f470848 ("vfio: Set DMA ownership for VFIO devices")
> Reported-by: Yishai Hadas <yishaih@xxxxxxxxxx>
> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

> ---
>  drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 1 +
>  drivers/vfio/pci/mlx5/main.c                   | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> index e92376837b29e6..4def43f5f7b619 100644
> --- a/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> +++ b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> @@ -1323,6 +1323,7 @@ static struct pci_driver hisi_acc_vfio_pci_driver = {
>  	.probe = hisi_acc_vfio_pci_probe,
>  	.remove = hisi_acc_vfio_pci_remove,
>  	.err_handler = &hisi_acc_vf_err_handlers,
> +	.driver_managed_dma = true,
>  };
> 
>  module_pci_driver(hisi_acc_vfio_pci_driver);
> diff --git a/drivers/vfio/pci/mlx5/main.c b/drivers/vfio/pci/mlx5/main.c
> index dd1009b5ff9c82..0558d0649ddb8c 100644
> --- a/drivers/vfio/pci/mlx5/main.c
> +++ b/drivers/vfio/pci/mlx5/main.c
> @@ -641,6 +641,7 @@ static struct pci_driver mlx5vf_pci_driver = {
>  	.probe = mlx5vf_pci_probe,
>  	.remove = mlx5vf_pci_remove,
>  	.err_handler = &mlx5vf_err_handlers,
> +	.driver_managed_dma = true,
>  };
> 
>  static void __exit mlx5vf_pci_cleanup(void)
> 
> base-commit: 9cfc47edbcd46edc6fb65ba00e7f12bacb1aab9c
> --
> 2.36.0





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux