Re: [Autotest] [Autotest PATCH] KVM-test: Fix a bug that pci_assignable type name mismatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 19, 2010 at 5:58 AM, Yolkfull Chow <yzhou@xxxxxxxxxx> wrote:
> The pci_assignable type name is nic_vf/nic_pf in kvm_utils.py whereas
> in kvm_vm.py they are vf/pf. Weird that why I tested it pass last week.
> Hope that it will not bring in any trouble before this patch applied.

Weird... Applied.

> Signed-off-by: Yolkfull Chow <yzhou@xxxxxxxxxx>
> ---
>  client/tests/kvm/kvm_utils.py |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py
> index 83aff66..df26a77 100644
> --- a/client/tests/kvm/kvm_utils.py
> +++ b/client/tests/kvm/kvm_utils.py
> @@ -971,12 +971,12 @@ class PciAssignable(object):
>     Request PCI assignable devices on host. It will check whether to request
>     PF (physical Functions) or VF (Virtual Functions).
>     """
> -    def __init__(self, type="nic_vf", driver=None, driver_option=None,
> +    def __init__(self, type="vf", driver=None, driver_option=None,
>                  names=None, devices_requested=None):
>         """
>         Initialize parameter 'type' which could be:
> -        nic_vf: Virtual Functions
> -        nic_pf: Physical Function (actual hardware)
> +        vf: Virtual Functions
> +        pf: Physical Function (actual hardware)
>         mixed:  Both includes VFs and PFs
>
>         If pass through Physical NIC cards, we need to specify which devices
> @@ -1087,9 +1087,9 @@ class PciAssignable(object):
>         @param count: count number of PCI devices needed for pass through
>         @return: a list of all devices' PCI IDs
>         """
> -        if self.type == "nic_vf":
> +        if self.type == "vf":
>             vf_ids = self.get_vf_devs()
> -        elif self.type == "nic_pf":
> +        elif self.type == "pf":
>             vf_ids = self.get_pf_devs()
>         elif self.type == "mixed":
>             vf_ids = self.get_vf_devs()
> --
> 1.5.5.6
>
> _______________________________________________
> Autotest mailing list
> Autotest@xxxxxxxxxxxxxxx
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>



-- 
Lucas
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux