Hi Abhishek, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on awilliam-vfio/next] [also build test WARNING on v5.18-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Abhishek-Sahu/vfio-pci-power-management-changes/20220517-180527 base: https://github.com/awilliam/linux-vfio.git next config: x86_64-randconfig-s021-20220516 (https://download.01.org/0day-ci/archive/20220518/202205180721.m3Z4ar57-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/intel-lab-lkp/linux/commit/2c439fb0dc917fb8bcf3cf432c8d73d51cfb16b0 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Abhishek-Sahu/vfio-pci-power-management-changes/20220517-180527 git checkout 2c439fb0dc917fb8bcf3cf432c8d73d51cfb16b0 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/vfio/pci/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> sparse warnings: (new ones prefixed by >>) >> drivers/vfio/pci/vfio_pci_config.c:411:20: sparse: sparse: restricted pci_power_t degrades to integer drivers/vfio/pci/vfio_pci_config.c:411:38: sparse: sparse: restricted pci_power_t degrades to integer vim +411 drivers/vfio/pci/vfio_pci_config.c 397 398 /* Caller should hold memory_lock semaphore */ 399 bool __vfio_pci_memory_enabled(struct vfio_pci_core_device *vdev) 400 { 401 struct pci_dev *pdev = vdev->pdev; 402 u16 cmd = le16_to_cpu(*(__le16 *)&vdev->vconfig[PCI_COMMAND]); 403 404 /* 405 * Memory region cannot be accessed if device power state is D3. 406 * 407 * SR-IOV VF memory enable is handled by the MSE bit in the 408 * PF SR-IOV capability, there's therefore no need to trigger 409 * faults based on the virtual value. 410 */ > 411 return pdev->current_state < PCI_D3hot && 412 (pdev->no_command_memory || (cmd & PCI_COMMAND_MEMORY)); 413 } 414 -- 0-DAY CI Kernel Test Service https://01.org/lkp
