On Mon, May 16, 2022 at 08:49:52PM +0000, Sean Christopherson wrote: >On Tue, May 03, 2022, Paolo Bonzini wrote: >> On 5/3/22 09:32, Zeng Guang wrote: >> > >> > I don't see "[PATCH v9 4/9] KVM: VMX: Report tertiary_exec_control field in >> > dump_vmcs()" in kvm/queue. Does it not need ? >> >> Added now (somehow the patches were not threaded, so I had to catch them one >> by one from lore). >> >> > Selftests for KVM_CAP_MAX_VCPU_ID is posted in V2 which is revised on top of >> > kvm/queue. >> > ([PATCH v2] kvm: selftests: Add KVM_CAP_MAX_VCPU_ID cap test - Zeng >> > Guang (kernel.org) <https://lore.kernel.org/lkml/20220503064037.10822-1-guang.zeng@xxxxxxxxx/>) >> >> Queued, thanks. > >Shouldn't we have a solution for the read-only APIC_ID mess before this is merged? We can add a new inhibit to disable APICv if guest attempts to change APIC ID when IPIv (or AVIC) is enabled. Maxim also thinks using a new inhibit is the right direction [1]. If no objection to this approach and Maxim doesn't have the patch, we can post one. But we will rely on Maxim to fix APIC ID mess for nested AVIC. [1] https://lore.kernel.org/all/6475522c58aec5db3ee0a5ccd3230c63a2f013a9.camel@xxxxxxxxxx/