Re: [kvm-unit-tests PATCH 3/6] s390x: uv-host: Test uv immediate parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 5/17/22 11:03, Janosch Frank wrote:
On 5/17/22 10:29, Steffen Eiden wrote:
Hey Janosch,

On 5/13/22 11:50, Janosch Frank wrote:
Let's check if we get a specification PGM exception if we set a
non-zero i3 when doing a UV call.

Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
---
   s390x/uv-host.c | 23 +++++++++++++++++++++++
   1 file changed, 23 insertions(+)

diff --git a/s390x/uv-host.c b/s390x/uv-host.c
index f846fc42..fcb82d24 100644
--- a/s390x/uv-host.c
+++ b/s390x/uv-host.c
@@ -64,6 +64,28 @@ static struct cmd_list cmds[] = {
       { NULL, 0, 0 },
   };
+static void test_i3(void)
+{
+    struct uv_cb_header uvcb = {
+        .cmd = UVC_CMD_INIT_UV,
+        .len = sizeof(struct uv_cb_init),
+    };
+    unsigned long r1 = 0;
Did you forgot 'r2' or is it missing for a reason?

The uvcb is the r2, have a look at the clobbers below

Oh right, my bad; Sorry.


+    int cc;
+
+    report_prefix_push("i3");
+    expect_pgm_int();
+    asm volatile(
+        "0:    .insn rrf,0xB9A40000,%[r1],%[r2],4,2\n"
+        "        ipm    %[cc]\n"
+        "        srl    %[cc],28\n"
+        : [cc] "=d" (cc)
+        : [r1] "a" (r1), [r2] "a" (&uvcb)
+        : "memory", "cc");
+    check_pgm_int_code(PGM_INT_CODE_SPECIFICATION);
+    report_prefix_pop();
+}
+
   static void test_priv(void)
   {
       struct uv_cb_header uvcb = {};
@@ -585,6 +607,7 @@ int main(void)
           goto done;
       }
+    test_i3();
       test_priv();
       test_invalid();
       test_uv_uninitialized();


--
Reviewed-by: Steffen Eiden <seiden@xxxxxxxxxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux