Re: [PATCH 4/5] KVM: Actually create debugfs in kvm_create_vm()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 16, 2022 at 3:19 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> On Fri, Apr 15, 2022, Oliver Upton wrote:
> > @@ -1049,7 +1050,7 @@ int __weak kvm_arch_create_vm_debugfs(struct kvm *kvm)
> >       return 0;
> >  }
> >
> > -static struct kvm *kvm_create_vm(unsigned long type)
> > +static struct kvm *kvm_create_vm(unsigned long type, int fd)
>
> I don't love passing in @fd, because actually doing anything but printing the
> @fd in a string is doomed to fail.
>
> Rather than pass the raw fd, what about passing in just its name?

Urgh. Yeah, that's fine by me. I'll squash this and resend.

--
Thanks,
Oliver



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux