On Mon, Jan 18, 2010 at 01:34:21PM +0200, Avi Kivity wrote: > On 01/11/2010 07:27 PM, Ryota Ozaki wrote: > >CPU hotplug feature is lost in this version. Even worse > >cpu_set qemu command may cause segfault. > > > >This patch fix the problem by just disabling it. It is > >enough for the stable branch. > > > >Signed-off-by: Ryota Ozaki<ozaki.ryota@xxxxxxxxx> > >Cc: Gleb Natapov<gleb@xxxxxxxxxx> > >--- > > monitor.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > >diff --git a/monitor.c b/monitor.c > >index 6ff6e1f..4b566d2 100644 > >--- a/monitor.c > >+++ b/monitor.c > >@@ -829,7 +829,9 @@ static void do_cpu_set_nr(Monitor *mon, const QDict > >*qdict) > > return; > > } > > #if defined(TARGET_I386) || defined(TARGET_X86_64) > >- qemu_system_cpu_hot_add(value, state); > >+ //qemu_system_cpu_hot_add(value, state); > >+ monitor_printf(mon, "The feature is not avaiable in this version. " > >+ "It will be back in a future version.\n"); > > #endif > > } > > Daniel, how is libvirt going to react to this? At this precise point in time it won't react since its not using it, but in a week's time when we have finished the libvirt code to use 'cpu_set' it'll be less happy ! Can't we actually fix CPU hotplug in the stable tree rather than just commenting it out ? Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
