Re: [PATCH 2/5] KVM: Shove vcpu stats_id init into kvm_vcpu_create_debugfs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 16, 2022 at 2:01 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> On Fri, Apr 15, 2022, Oliver Upton wrote:
> > Again, the stats_id is only ever used by the stats code; put it where it
> > belongs with the rest of the stats initialization.
>
> Heh, again, no?  Ah, but here you've conflated debugfs and stats in the changelog.
> They are two different things.  And most critically, stats is not dependent on debugfs.

Agreed. Patch 1 and 2 arise from being bitter that struct kvm and
struct kvm_vcpu fields are initialized out of line with other fields.
I'll yank these into kvm_create_vm() and kvm_vcpu_init(),
respectively.

--
Thanks,
Oliver



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux