On Wed, May 11, 2022, Maxim Levitsky wrote: > On Thu, 2022-04-14 at 15:19 +0200, Vitaly Kuznetsov wrote: > > @@ -2089,8 +2108,8 @@ static u64 kvm_hv_flush_tlb(struct kvm_vcpu *vcpu, struct kvm_hv_hcall *hc) > > ((u64)hc->rep_cnt << HV_HYPERCALL_REP_COMP_OFFSET); > > } > > > > -static void kvm_send_ipi_to_many(struct kvm *kvm, u32 vector, > > - unsigned long *vcpu_bitmap) > > +static void kvm_hv_send_ipi_to_many(struct kvm *kvm, u32 vector, > > + u64 *sparse_banks, u64 valid_bank_mask) > I think the indentation is wrong here (was wrong before as well) It's correct, the "+" from the diff/patch misaligns the first line because there's no tab to eat the extra character. Amusingly, the misaligment just gets worse the more ">" / quotes that get added to the front. I usually end up applying a patch to double check if I suspect indentation is wrong, it's too hard for me to tell based on the raw patch alone unless it's super bad/obvious.