On 5/10/22 12:58, Nico Boehr wrote:
On Mon, 2022-05-09 at 16:00 +0200, Claudio Imbrenda wrote:
I wonder if we are going to have more of these "split" tests.
is there a way to make sure migration prerequisites are always
present?
We could not run _any_ tests if netcat is not installed, which seems
like a bad idea.
or rewrite things so that we don't need them?
We need ncat to communicate with the QEMU QMP over unix socket. I am
not aware of a way to use unix sockets in Bash, but no expert either.
We could ship our own version of netcat and build it for the host,
which adds additional complexity and maintenance burden.
I honestly can't think of a good way.
Or we just put all cmm tests in a single file and accept the fact that
if you don't have all the migration related requirements installed, you
don't get all the tests - even some which are not at all related to
migration. I did not like that so I went with the extra file.
Having them separate is fine. I'd change the file name to
migration-cmm.elf though. We might also want to change the name of the
first migration test in the future to make the name more specific.
