Re: [PATCH] x86: Function missing integer return value

[Juergen Gross <jgross@xxxxxxxx>]

On 05.05.22 13:32, Li kunyu wrote:
> This function may need to return a value
>
> Signed-off-by: Li kunyu <kunyu@xxxxxxxxxxxx>
> ---
>   arch/x86/kvm/mmu/mmu.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index 64a2a7e2be90..68f33b932f94 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -6500,6 +6500,8 @@ static int kvm_nx_lpage_recovery_worker(struct kvm *kvm, uintptr_t data)
>   
>   		kvm_recover_nx_lpages(kvm);
>   	}
> +
> +	return 0;

This statement is not reachable, so the patch is adding unneeded dead
code only.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature