On Wed, May 04, 2022 at 03:15:35PM +0000, Shameerali Kolothum Thodi wrote: > > Further, since the drvdata holds a positive refcount on the vfio_device > > any access of the drvdata, under the driver_lock, from a driver callback > > device_lock() ? (v1 discussion says it's a typo). Yes, I fixed it > > needs no further protection or refcounting. > > > > Thus the remark in the vfio_device_get_from_dev() comment does not apply > > here, VFIO PCI drivers all call vfio_unregister_group_dev() from their > > remove callbacks under the driver lock and cannot race with the remaining > > callers. > > May be we can also mention the removal of vfio_group_get_from_dev() as well > in the commit. It is in the subject :) Thanks, Jason
