On 26.04.2022 01:01, Maciej S. Szmigiero wrote:
On 23.04.2022 04:14, Sean Christopherson wrote:
Fix soft interrupt/exception reinjection on SVM.
Thanks for the patch set Sean, I can't see anything being obviously wrong
during a static code review - just small nits.
Will test it practically tomorrow and report the results.
I've tested this patch set and it seems to work fine with respect
to soft {exception,interrupt} re-injection and next_rip field consistency.
I have prepared a draft of an updated version at [1] with the following
further changes:
* "Downgraded" the commit affecting !nrips CPUs to just drop nested SVM
support for such parts instead of SVM support in general,
* Added a fix for L1/L2 NMI state confusion during L1 -> L2 NMI re-injection,
* Updated the new KVM self-test to also check for the NMI injection
scenario being fixed (that was found causing issues with a real guest),
* Changed "kvm_inj_virq" trace event "reinjected" field type to bool.
Will post a v3 patch set (with proper SoBs, etc.) if there are no further
comments or objections.
Thanks,
Maciej
[1]: https://github.com/maciejsszmigiero/linux/commits/svm_next_rip-sc