On 4/13/22 9:57 PM, Sean Christopherson wrote: > On Tue, Apr 12, 2022, Varad Gautam wrote: >> This series brings multi-vcpu support to UEFI tests on x86. >> >> Most of the necessary AP bringup code already exists within kvm-unit-tests' >> cstart64.S, and has now been either rewritten in C or moved to a common location >> to be shared between EFI and non-EFI test builds. >> >> A call gate is used to transition from 16-bit to 32-bit mode, since EFI may >> not load the 32-bit entrypoint low enough to be reachable from the SIPI vector. >> >> Changes in v2: >> - rebase onto kvm-unit-tests@1a4529ce83 + seanjc's percpu apic_ops series [1]. > > Thanks for taking on the rebase pain, I appreciate it! > > Lots of comments, but mostly minor things to (hopefully) improve readability. I > belive the mixup with 32-bit targets is the only thing that might get painful. > I've sent out a v3 at [1] taking in most of your comments. I've only left out the changes to non-EFI 32-bit asm bringup code (x86/start32.S) and some renames which I think would better go into a different series to keep this one easier to follow. [1] https://lore.kernel.org/kvm/20220426114352.1262-1-varad.gautam@xxxxxxxx/ Thanks, Varad
