On Thu, Apr 21, 2022 at 10:57:06PM +0800, Yi Liu wrote: > On 2022/4/21 03:23, Jason Gunthorpe wrote: > > The only user wants to get a pointer to the struct iommu_group associated > > with the VFIO group file being used. > > Not native speaker, but above line is a little bit difficlut to interpret. > > "What user wants is to get a pointer to the struct iommu_group associated > with the VFIO group file being used." How about this: The only caller wants to get a pointer to the struct iommu_group associated with the VFIO group file. Instead of returning the group ID then searching sysfs for that string to get the struct iommu_group just directly return the iommu_group pointer already held by the vfio_group struct. Jason