Re: [RFC PATCH v5 045/104] KVM: x86/tdp_mmu: make REMOVED_SPTE include shadow_initial value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC PATCH v5 045/104] KVM: x86/tdp_mmu: make REMOVED_SPTE include shadow_initial value
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Thu, 7 Apr 2022 15:52:58 +0200
Cc: isaku.yamahata@xxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, isaku.yamahata@xxxxxxxxx, Jim Mattson <jmattson@xxxxxxxxxx>, erdemaktas@xxxxxxxxxx, Connor Kuehl <ckuehl@xxxxxxxxxx>
In-reply-to: <Yk4j0cCR5fnQKw1F@google.com>
References: <cover.1646422845.git.isaku.yamahata@intel.com> <6614d2a2bc34441ed598830392b425fdf8e5ca52.1646422845.git.isaku.yamahata@intel.com> <3f93de19-0685-3045-22db-7e05492bb5a4@redhat.com> <Yk4j0cCR5fnQKw1F@google.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 4/7/22 01:35, Sean Christopherson wrote:

Please rename the existing REMOVED_SPTE to REMOVED_SPTE_MASK, and call this
simply REMOVED_SPTE.  This also makes the patch smaller.

Can we name it either __REMOVE_SPTE or REMOVED_SPTE_VAL?  It's most definitely
not a mask, it's a full value, e.g. spte |= REMOVED_SPTE_MASK is completely wrong.


REMOVED_SPTE_VAL is fine.

Paolo

References:
- [RFC PATCH v5 000/104] KVM TDX basic feature support
  - From: isaku . yamahata
- [RFC PATCH v5 045/104] KVM: x86/tdp_mmu: make REMOVED_SPTE include shadow_initial value
  - From: isaku . yamahata
- Re: [RFC PATCH v5 045/104] KVM: x86/tdp_mmu: make REMOVED_SPTE include shadow_initial value
  - From: Paolo Bonzini
- Re: [RFC PATCH v5 045/104] KVM: x86/tdp_mmu: make REMOVED_SPTE include shadow_initial value
  - From: Sean Christopherson

Prev by Date: Re: [RFC PATCH v5 047/104] KVM: x86/mmu: add a private pointer to struct kvm_mmu_page
Next by Date: Re: [RFC PATCH v5 092/104] KVM: TDX: Handle TDX PV HLT hypercall
Previous by thread: Re: [RFC PATCH v5 045/104] KVM: x86/tdp_mmu: make REMOVED_SPTE include shadow_initial value
Next by thread: Re: [RFC PATCH v5 045/104] KVM: x86/tdp_mmu: make REMOVED_SPTE include shadow_initial value
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]