Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 6 Apr 2022 15:51:50 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>, Christian Benvenuti <benve@xxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Gerald Schaefer <gerald.schaefer@xxxxxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, Jason Wang <jasowang@xxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Nelson Escobar <neescoba@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Rob Clark <robdclark@xxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Will Deacon <will@xxxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>
In-reply-to: <20220406120730.GA2120790@nvidia.com>
References: <0-v1-ef02c60ddb76+12ca2-intel_no_snoop_jgg@nvidia.com> <1-v1-ef02c60ddb76+12ca2-intel_no_snoop_jgg@nvidia.com> <20220406053039.GA10580@lst.de> <20220406120730.GA2120790@nvidia.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Wed, Apr 06, 2022 at 09:07:30AM -0300, Jason Gunthorpe wrote:
> Didn't see it
> 
> I'll move dev_is_dma_coherent to device.h along with
> device_iommu_mapped() and others then

No.  It it is internal for a reason.  It also doesn't actually work
outside of the dma core.  E.g. for non-swiotlb ARM configs it will
not actually work.

Follow-Ups:
- Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()
  - From: Jason Gunthorpe

References:
- [PATCH 0/5] Make the iommu driver no-snoop block feature consistent
  - From: Jason Gunthorpe
- [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()
  - From: Jason Gunthorpe
- Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()
  - From: Christoph Hellwig
- Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()
  - From: Jason Gunthorpe

Prev by Date: Re: [kvm-unit-tests PATCH v3 04/11] lib: x86: Import insn decoder from Linux
Next by Date: Re: [PATCH 5/8] KVM: SVM: Re-inject INT3/INTO instead of retrying the instruction
Previous by thread: Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()
Next by thread: Re: [PATCH 1/5] iommu: Replace uses of IOMMU_CAP_CACHE_COHERENCY with dev_is_dma_coherent()
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]