On Thu, Mar 31, 2022 at 04:31:10PM +1300, Kai Huang <kai.huang@xxxxxxxxx> wrote: > On Fri, 2022-03-04 at 11:48 -0800, isaku.yamahata@xxxxxxxxx wrote: > > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx> > > Add a wrapper function to initialize the TDX module and get system-wide > > parameters via those APIs. Because TDX requires VMX enabled, It will be > > called on-demand when the first guest TD is created via x86 KVM init_vm > > callback. > > Why not just merge this patch with the change where you implement the init_vm > callback? Then you can just declare this patch as "detect and initialize TDX > module when first VM is created", or something like that.. Ok. Anyway in the next respoin, tdx module initialization will be done when loading kvm_intel.ko. So the whole part will be changed and will be a part of module loading. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>