On Wed, Mar 30, 2022 at 11:02 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > On Wed, Mar 30, 2022, Ben Gardon wrote: > > Ensure that the userspace actor attempting to disable NX hugepages has > > permission to reboot the system. Since disabling NX hugepages would > > allow a guest to crash the system, it is similar to reboot permissions. > > This patch needs to be squashed with the patch that introduces the capability, > otherwise you're introdcuing a bug and then fixing it in the same series. I'm happy to do that. I figured that leaving it as a separate patch would provide an easy way to separate the discussion on how to implement the new cap versus how to restrict it. I don't know if I'd consider not having this patch a bug, especially since it can make testing kind of a pain, but I see your point.