The PCI access size type is changed from a signed type
to an unsigned type since the size is never expected to
be negative, and the type also matches the type in the
signature of virtio_pci__io_mmio_callback.
This change simplifies size checking in the next patch.
Signed-off-by: Martin Radev <martin.b.radev@xxxxxxxxx>
---
virtio/pci.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/virtio/pci.c b/virtio/pci.c
index 2777d1c..bcb205a 100644
--- a/virtio/pci.c
+++ b/virtio/pci.c
@@ -116,7 +116,7 @@ static inline bool virtio_pci__msix_enabled(struct virtio_pci *vpci)
}
static bool virtio_pci__specific_data_in(struct kvm *kvm, struct virtio_device *vdev,
- void *data, int size, unsigned long offset)
+ void *data, u32 size, unsigned long offset)
{
u32 config_offset;
struct virtio_pci *vpci = vdev->virtio;
@@ -146,7 +146,7 @@ static bool virtio_pci__specific_data_in(struct kvm *kvm, struct virtio_device *
}
static bool virtio_pci__data_in(struct kvm_cpu *vcpu, struct virtio_device *vdev,
- unsigned long offset, void *data, int size)
+ unsigned long offset, void *data, u32 size)
{
bool ret = true;
struct virtio_pci *vpci;
@@ -211,7 +211,7 @@ static void update_msix_map(struct virtio_pci *vpci,
}
static bool virtio_pci__specific_data_out(struct kvm *kvm, struct virtio_device *vdev,
- void *data, int size, unsigned long offset)
+ void *data, u32 size, unsigned long offset)
{
struct virtio_pci *vpci = vdev->virtio;
u32 config_offset, vec;
@@ -285,7 +285,7 @@ static bool virtio_pci__specific_data_out(struct kvm *kvm, struct virtio_device
}
static bool virtio_pci__data_out(struct kvm_cpu *vcpu, struct virtio_device *vdev,
- unsigned long offset, void *data, int size)
+ unsigned long offset, void *data, u32 size)
{
bool ret = true;
struct virtio_pci *vpci;
--
2.25.1
Original patch but with comments addressed:
