On Mon, Mar 21, 2022 at 02:00:39PM +0000, Will Deacon wrote: > Hi Sebastian, > Hello Will, > On Sun, Mar 13, 2022 at 04:19:47PM +0000, Sebastian Ene wrote: > > This series adds support for stolen time functionality. > > > > Patch #1 moves the vCPU structure initialisation before the target->init() > > call to allow early access to the kvm structure from the vCPU > > during target->init(). > > > > Patch #2 modifies the memory layout in arm-common/kvm-arch.h and adds a > > new MMIO device PVTIME after the RTC region. A new flag is added in > > kvm-config.h that will be used to control [enable/disable] the pvtime > > functionality. Stolen time is enabled by default when the host > > supports KVM_CAP_STEAL_TIME. > > > > Patch #3 adds a new command line argument to disable the stolen time > > functionality(by default is enabled). > > > > Changelog since v10: > > - set the return value to -errno on failed exit path from > > 'kvm_cpu__setup_pvtime' > > Thanks. I've applied this, but I think it would be worth a patch on top > to make the new '--no-pvtime' option part of the 'arch-specific' options > rather than a generic option given that this is only implemented for > arm64 at the moment. > > Please could you send an extra patch to move the option? You can look at > how we deal with the other arm64-specific options in > arm/aarch64/include/kvm/kvm-config-arch.h for inspiration. > Thanks for the feedback, I will add it as an arm64-specific option. > Cheers, > > Will Thanks, Sebastian
