On Mon, Mar 21, 2022 at 06:17:43AM +0000, Oliver Upton wrote: > Hi Reiji, > > On Sun, Mar 20, 2022 at 10:08:04PM -0700, Reiji Watanabe wrote: [...] > > +#define _GNU_SOURCE > > In other instances where we define _GNU_SOURCE, it is said we do it for > program_invocation_short_name. Nonetheless, I cannot find anywhere that > the symbol is actually being used. > > This looks to be some leftover crud from our internal test library > before we upstreamed KVM selftests a few years ago. > Ah, it's because we're actually using program_invocation_name. This already gets defined in lib/kvm_util.c, so except for a few oddball tests that directly call kvm_vm_elf_load(), this is unnecessary. -- Thanks, Oliver
