On Thu, Mar 17, 2022 at 09:58:43PM +0800, Xiaoyao Li <xiaoyao.li@xxxxxxxxx> wrote: > diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c > index e3b94373b316..bed337e5ba18 100644 > --- a/target/i386/kvm/tdx.c > +++ b/target/i386/kvm/tdx.c > @@ -14,10 +14,77 @@ > #include "qemu/osdep.h" > #include "qapi/error.h" > #include "qom/object_interfaces.h" > +#include "sysemu/kvm.h" > > #include "hw/i386/x86.h" > #include "tdx.h" > > +enum tdx_ioctl_level{ > + TDX_VM_IOCTL, > + TDX_VCPU_IOCTL, > +}; > + > +static int __tdx_ioctl(void *state, enum tdx_ioctl_level level, int cmd_id, > + __u32 metadata, void *data) > +{ > + struct kvm_tdx_cmd tdx_cmd; > + int r; > + > + memset(&tdx_cmd, 0x0, sizeof(tdx_cmd)); > + > + tdx_cmd.id = cmd_id; > + tdx_cmd.metadata = metadata; > + tdx_cmd.data = (__u64)(unsigned long)data; > + > + switch (level) { > + case TDX_VM_IOCTL: > + r = kvm_vm_ioctl(kvm_state, KVM_MEMORY_ENCRYPT_OP, &tdx_cmd); > + break; > + case TDX_VCPU_IOCTL: > + r = kvm_vcpu_ioctl(state, KVM_MEMORY_ENCRYPT_OP, &tdx_cmd); > + break; > + default: > + error_report("Invalid tdx_ioctl_level %d", level); > + exit(1); > + } > + > + return r; > +} > + > +#define tdx_vm_ioctl(cmd_id, metadata, data) \ > + __tdx_ioctl(NULL, TDX_VM_IOCTL, cmd_id, metadata, data) > + > +#define tdx_vcpu_ioctl(cpu, cmd_id, metadata, data) \ > + __tdx_ioctl(cpu, TDX_VCPU_IOCTL, cmd_id, metadata, data) No point to use macro. Normal (inline) function can works. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>