On Fri, Mar 11, 2022 at 12:25:21AM +0000, David Matlack wrote: > drop_large_spte() drops a large SPTE if it exists and then flushes TLBs. > Its helper function, __drop_large_spte(), does the drop without the > flush. > > In preparation for eager page splitting, which will need to sometimes > flush when dropping large SPTEs (and sometimes not), push the flushing > logic down into __drop_large_spte() and add a bool parameter to control > it. > > No functional change intended. > > Signed-off-by: David Matlack <dmatlack@xxxxxxxxxx> The new helpers looks much better indeed.. Reviewed-by: Peter Xu <peterx@xxxxxxxxxx> -- Peter Xu