On Tue, 2022-03-08 at 17:59 +0100, David Woodhouse wrote: > > kvm/queue is rebased routinely, so I'll just squash (only the first > > hunk, methinks). Got a testcase, though? That might be better as a > > separate patch. > > My test case right now is to run 'while true; time sleep 1; done' in > the guest while I repeatedly kexec / live update the host. > > After a kexec, the deadline for the timer is past, and that's why it > ends up getting restored with a negative delta. After a *few* cycles of > this it usually ends up with the timer callback never triggering. > > I'll stick a negative delta into the KVM selftest included in the patch > series, instead of the nice polite '100ms in the future' that it uses > at the moment. That ought to trigger it too, and I can instrument the > hrtimer code to work out what's going on. Either way, I think 'Don't Do > That Then' will continue to be the right answer :) Oh, I bet that won't show it and the kexec is actually needed. I bet it only happens when the timer expiry is actually at a time *before* zero on the new kernel's clock.
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
