Re: KSM overcommit test review - 1st pass (issue183068)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jiri, thank you very much for your work! I have comments to make
regarding to coding style as a first pass review. While reading them,
please keep in mind autotest's coding standards:

http://autotest.kernel.org/browser/trunk/CODING_STYLE

Also, I have noticed lots of trailing spaces on lines. I recommend that
every time you are done working with the code, you use the very useful
script utils/reindent.py (see top level autotest directory) that will
remove all trailing spaces on your code. While I wrote this first pass
review, I have applied it on the resultant files.


http://codereview.appspot.com/183068
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux