Hi,
On Mon, Mar 07, 2022 at 02:42:42PM +0000, Sebastian Ene wrote:
> Move the vCPU structure initialisation before the target->init() call to
> keep a reference to the kvm structure during init().
> This is required by the pvtime peripheral to reserve a memory region
> while the vCPU is beeing initialised.
>
> Signed-off-by: Sebastian Ene <sebastianene@xxxxxxxxxx>
I think you're missing Marc's Reviewed-by tag.
Thanks,
Alex
> ---
> arm/kvm-cpu.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arm/kvm-cpu.c b/arm/kvm-cpu.c
> index 6a2408c..84ac1e9 100644
> --- a/arm/kvm-cpu.c
> +++ b/arm/kvm-cpu.c
> @@ -116,6 +116,13 @@ struct kvm_cpu *kvm_cpu__arch_init(struct kvm *kvm, unsigned long cpu_id)
> die("Unable to find matching target");
> }
>
> + /* Populate the vcpu structure. */
> + vcpu->kvm = kvm;
> + vcpu->cpu_id = cpu_id;
> + vcpu->cpu_type = vcpu_init.target;
> + vcpu->cpu_compatible = target->compatible;
> + vcpu->is_running = true;
> +
> if (err || target->init(vcpu))
> die("Unable to initialise vcpu");
>
> @@ -125,13 +132,6 @@ struct kvm_cpu *kvm_cpu__arch_init(struct kvm *kvm, unsigned long cpu_id)
> vcpu->ring = (void *)vcpu->kvm_run +
> (coalesced_offset * PAGE_SIZE);
>
> - /* Populate the vcpu structure. */
> - vcpu->kvm = kvm;
> - vcpu->cpu_id = cpu_id;
> - vcpu->cpu_type = vcpu_init.target;
> - vcpu->cpu_compatible = target->compatible;
> - vcpu->is_running = true;
> -
> if (kvm_cpu__configure_features(vcpu))
> die("Unable to configure requested vcpu features");
>
> --
> 2.35.1.616.g0bdcbb4464-goog
>
> _______________________________________________
> kvmarm mailing list
> kvmarm@xxxxxxxxxxxxxxxxxxxxx
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
