On 2/28/2022 11:47 AM, Manali Shukla wrote: > Commit 916635a813e975600335c6c47250881b7a328971 > (nSVM: Add test for NPT reserved bit and #NPF error code behavior) > clears PT_USER_MASK for all svm testcases. Any tests that requires > usermode access will fail after this commit. > > If __setup_vm() is changed to setup_vm(), KUT will build tests with > PT_USER_MASK set on all PTEs. It is a better idea to move nNPT tests > to their own file so that tests don't need to fiddle with page tables > midway. > > The quick approach to do this would be to turn the current main into a small > helper, without calling __setup_vm() from helper. > > There are three patches in this patch series > 1) Turned current main into helper function minus setup_vm() > 2) Moved all nNPT test cases from svm_tests.c to svm_npt.c > 3) Change __setup_vm to setup_vm() on svm_tests.c > > Manali Shukla (3): > x86: nSVM: Move common functionality of the main() to helper > run_svm_tests > x86: nSVM: Move all nNPT test cases from svm_tests.c to a seperate > file. > x86: nSVM: Allow nSVM tests run with PT_USER_MASK enabled > > x86/Makefile.common | 2 + > x86/Makefile.x86_64 | 2 + > x86/svm.c | 6 +- > x86/svm.h | 1 + > x86/svm_npt.c | 386 ++++++++++++++++++++++++++++++++++++++++++++ > x86/svm_tests.c | 369 +----------------------------------------- > 6 files changed, 398 insertions(+), 368 deletions(-) > create mode 100644 x86/svm_npt.c > A gentle reminder for review Thanks Manali
