On Thu, Feb 24, 2022 at 10:25 PM Gautam Dawar <gautam.dawar@xxxxxxxxxx> wrote: > > This patch introduces a new bus operation to allow the vDPA bus driver > to associate an ASID to a virtqueue group. > > Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx> > Signed-off-by: Gautam Dawar <gdawar@xxxxxxxxxx> > --- > include/linux/vdpa.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h > index de22ca1a8ef3..7386860c3995 100644 > --- a/include/linux/vdpa.h > +++ b/include/linux/vdpa.h > @@ -239,6 +239,12 @@ struct vdpa_map_file { > * @vdev: vdpa device > * Returns the iova range supported by > * the device. > + * @set_group_asid: Set address space identifier for a > + * virtqueue group > + * @vdev: vdpa device > + * @group: virtqueue group > + * @asid: address space id for this group > + * Returns integer: success (0) or error (< 0) > * @set_map: Set device memory mapping (optional) > * Needed for device that using device > * specific DMA translation (on-chip IOMMU) > @@ -321,6 +327,10 @@ struct vdpa_config_ops { > u64 iova, u64 size, u64 pa, u32 perm, void *opaque); > int (*dma_unmap)(struct vdpa_device *vdev, unsigned int asid, > u64 iova, u64 size); > + int (*set_group_asid)(struct vdpa_device *vdev, unsigned int group, > + unsigned int asid); > + > + Nit again, and Jason's patch already contained these, but I think these two blank lines are introduced unintentionally. > > /* Free device resources */ > void (*free)(struct vdpa_device *vdev); > -- > 2.25.0 >