[PATCH v2 kvmtool 0/5] Fix few small issues in virtio code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello everyone,

Thanks for the reviews in the first patch set.

This is the second version of the original patch set which addresses
few found overflows in the common virtio code. Since the first version,
the following changes were made:
- the virtio_net warning patch was removed.
- a WARN_ONCE macro is added to help signal that an issue was observed,
  but without polluting the log.
- a couple of improvements in sanitization and style.
- TODO comment for missing handling of multi-byte PCI accesses.

The Makefile change is kept in its original form because I didn't understand
if there is an issue with it on aarch64.

Martin Radev (5):
  kvmtool: Add WARN_ONCE macro
  virtio: Sanitize config accesses
  virtio: Check for overflows in QUEUE_NOTIFY and QUEUE_SEL
  Makefile: Mark stack as not executable
  mmio: Sanitize addr and len

 Makefile                |  7 +++--
 include/kvm/util.h      | 10 +++++++
 include/kvm/virtio-9p.h |  1 +
 include/kvm/virtio.h    |  3 ++-
 mmio.c                  |  4 +++
 virtio/9p.c             | 27 ++++++++++++++-----
 virtio/balloon.c        | 10 ++++++-
 virtio/blk.c            | 10 ++++++-
 virtio/console.c        | 10 ++++++-
 virtio/mmio.c           | 44 +++++++++++++++++++++++++-----
 virtio/net.c            | 12 +++++++--
 virtio/pci.c            | 59 ++++++++++++++++++++++++++++++++++++++---
 virtio/rng.c            |  8 +++++-
 virtio/scsi.c           | 10 ++++++-
 virtio/vsock.c          | 10 ++++++-
 15 files changed, 199 insertions(+), 26 deletions(-)

-- 
2.25.1




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux