Hi Marcelo,
Avi has already fixed this particular problem in the meantime, but
I checked and your patch fixes build problem as well..
thanks!
have a nice day
nik
On Thu, Dec 24, 2009 at 02:25:11PM -0200, Marcelo Tosatti wrote:
> On Tue, Dec 22, 2009 at 03:07:36PM +0100, Nikola Ciprich wrote:
> > CentOS5, all packages updated.
> > But I just noticed build fails only when configured with multiple targets,
> > including some more exotic (based on fedora spec).
> > building just using x86_64-softmmu works fine for me.
> > n.
> > On Tue, Dec 22, 2009 at 03:43:32PM +0200, Avi Kivity wrote:
> > > On 12/22/2009 03:35 PM, Nikola Ciprich wrote:
> > > >sorry to bring bad news, but it still doesn't compile (at least for me):
> > > >
> > > >[root@vmdev03 qemu-kvm-0.12.1.1]# make
> > > > LINK x86_64-softmmu/qemu-system-x86_64
> > > >machine.o: In function `cpu_pre_save':
> > > >/usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
> > > >collect2: ld returned 1 exit status
> > > >make[1]: *** [qemu-system-x86_64] Error 1
> > > >make: *** [subdir-x86_64-softmmu] Error 2
>
> Nikola,
>
> Can you please confirm the attached patch fixes the undefined reference
> problem for you?
>
> Thanks
>
> diff --git a/qemu-kvm.h b/qemu-kvm.h
> index a81ff12..6b3e5a1 100644
> --- a/qemu-kvm.h
> +++ b/qemu-kvm.h
> @@ -1070,6 +1070,7 @@ void kvm_load_tsc(CPUState *env);
> #endif
> #define kvm_load_registers(env) do {} while(0)
> #define kvm_save_registers(env) do {} while(0)
> +#define kvm_save_mpstate(env) do {} while(0)
> #define qemu_kvm_cpu_stop(env) do {} while(0)
> static inline void kvm_init_vcpu(CPUState *env)
> {
--
-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava
tel.: +420 596 603 142
fax: +420 596 621 273
mobil: +420 777 093 799
www.linuxbox.cz
mobil servis: +420 737 238 656
email servis: servis@xxxxxxxxxxx
-------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
