On Wed, Mar 02, 2022 at 06:38:07PM +0100, Philippe Mathieu-Daudé wrote: > On 2/3/22 18:31, Sergio Lopez wrote: > > On Wed, Mar 02, 2022 at 06:18:59PM +0100, Philippe Mathieu-Daudé wrote: > > > On 2/3/22 18:10, Paolo Bonzini wrote: > > > > On 3/2/22 12:36, Sergio Lopez wrote: > > > > > With the possibility of using pipefd as a replacement on operating > > > > > systems that doesn't support eventfd, vhost-user can also work on BSD > > > > > systems. > > > > > > > > > > This change allows enabling vhost-user on BSD platforms too and > > > > > makes libvhost_user (which still depends on eventfd) a linux-only > > > > > feature. > > > > > > > > > > Signed-off-by: Sergio Lopez <slp@xxxxxxxxxx> > > > > > > > > I would just check for !windows. > > > > > > What about Darwin / Haiku / Illumnos? > > > > It should work on every system providing pipe() or pipe2(), so I guess > > Paolo's right, every platform except Windows. FWIW, I already tested > > it with Darwin. > > Wow, nice. > > So maybe simply check for pipe/pipe2 rather than !windows? > Is it worth it? In "configure", CONFIG_POSIX is set to "y" if the target isn't "mingw32", and CONFIG_POSIX brings "util/oslib-posix.c" into the build, which expects to have either pipe or pipe2. Thanks, Sergio.
Attachment:
signature.asc
Description: PGP signature
