Re: [kvm-unit-tests PATCH RESEND 1/2] x86/pmu: Make "ref cycles" test to pass on the latest cpu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 2, 2022 at 3:26 AM Like Xu <like.xu.linux@xxxxxxxxx> wrote:
>
> From: Like Xu <likexu@xxxxxxxxxxx>
>
> Expand the boundary for "ref cycles" event test as it has
> been observed that the results do not fit on some CPUs [1]:
>
> FAIL: full-width writes: ref cycles-N
>   100000 >= 87765 <= 30000000
>   100000 >= 87926 <= 30000000
>   100000 >= 87790 <= 30000000
>   100000 >= 87687 <= 30000000
>   100000 >= 87875 <= 30000000
>   100000 >= 88043 <= 30000000
>   100000 >= 88161 <= 30000000
>   100000 >= 88052 <= 30000000
>
> [1] Intel(R) Xeon(R) Platinum 8374C CPU @ 2.70GHz
>
> Opportunistically fix cc1 warnings for commented print statement.
>
> Signed-off-by: Like Xu <likexu@xxxxxxxxxxx>

This fix doesn't address the root cause of the problem, which is that
the general purpose reference cycles event is, in many cases,
decoupled from CPI. My proposed fix,
https://lore.kernel.org/kvm/20220213082714.636061-1-jmattson@xxxxxxxxxx/,
does.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux