On 3/2/22 17:06, Stefan Hajnoczi wrote:
I agree. In fact, that's what I implemented in the first place. I
changed to this version in which event_notifier_get_fd() is extended
because it feels more "correct". But yes, the pragmatic option would
be adding a new event_notifier_get_wfd().
I'll wait for more reviews, and unless someone voices against it, I'll
respin the patches with that strategy (I already have it around here).
I had the same thought looking through the patch before I read Alex's
suggestion. A separate get_wfd() function makes sense to me.
And that's four with me. :) It's not just pragmatic, I cannot imagine a
case where the caller doesn't know exactly which of the two file
descriptors they want.
Paolo
