On Fri, 2022-02-25 at 16:22 +0800, Zeng Guang wrote: > From: Robert Hoo <robert.hu@xxxxxxxxxxxxxxx> > > Add tertiary_exec_control field report in dump_vmcs() > > Signed-off-by: Robert Hoo <robert.hu@xxxxxxxxxxxxxxx> > Signed-off-by: Zeng Guang <guang.zeng@xxxxxxxxx> > --- > arch/x86/kvm/vmx/vmx.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index 8a5713d49635..7beba7a9f247 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -5891,6 +5891,7 @@ void dump_vmcs(struct kvm_vcpu *vcpu) > struct vcpu_vmx *vmx = to_vmx(vcpu); > u32 vmentry_ctl, vmexit_ctl; > u32 cpu_based_exec_ctrl, pin_based_exec_ctrl, secondary_exec_control; > + u64 tertiary_exec_control; > unsigned long cr4; > int efer_slot; > > @@ -5904,9 +5905,16 @@ void dump_vmcs(struct kvm_vcpu *vcpu) > cpu_based_exec_ctrl = vmcs_read32(CPU_BASED_VM_EXEC_CONTROL); > pin_based_exec_ctrl = vmcs_read32(PIN_BASED_VM_EXEC_CONTROL); > cr4 = vmcs_readl(GUEST_CR4); > - secondary_exec_control = 0; > + > if (cpu_has_secondary_exec_ctrls()) > secondary_exec_control = vmcs_read32(SECONDARY_VM_EXEC_CONTROL); > + else > + secondary_exec_control = 0; > + > + if (cpu_has_tertiary_exec_ctrls()) > + tertiary_exec_control = vmcs_read64(TERTIARY_VM_EXEC_CONTROL); > + else > + tertiary_exec_control = 0; > > pr_err("VMCS %p, last attempted VM-entry on CPU %d\n", > vmx->loaded_vmcs->vmcs, vcpu->arch.last_vmentry_cpu); > @@ -6006,9 +6014,10 @@ void dump_vmcs(struct kvm_vcpu *vcpu) > vmx_dump_msrs("host autoload", &vmx->msr_autoload.host); > > pr_err("*** Control State ***\n"); > - pr_err("PinBased=%08x CPUBased=%08x SecondaryExec=%08x\n", > - pin_based_exec_ctrl, cpu_based_exec_ctrl, secondary_exec_control); > - pr_err("EntryControls=%08x ExitControls=%08x\n", vmentry_ctl, vmexit_ctl); > + pr_err("CPUBased=0x%08x SecondaryExec=0x%08x TertiaryExec=0x%016llx\n", > + cpu_based_exec_ctrl, secondary_exec_control, tertiary_exec_control); > + pr_err("PinBased=0x%08x EntryControls=%08x ExitControls=%08x\n", > + pin_based_exec_ctrl, vmentry_ctl, vmexit_ctl); > pr_err("ExceptionBitmap=%08x PFECmask=%08x PFECmatch=%08x\n", > vmcs_read32(EXCEPTION_BITMAP), > vmcs_read32(PAGE_FAULT_ERROR_CODE_MASK), Reviewed-by: Maxim Levitsky <mlevitsk@xxxxxxxxxx> Best regards, Maxim Levitsky