On Fri, Feb 25, 2022 at 1:53 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Fri, Feb 25, 2022 at 01:48:48PM +0100, Jason A. Donenfeld wrote: > > +static struct acpi_driver acpi_driver = { > > + .name = "vmgenid", > > + .ids = vmgenid_ids, > > + .owner = THIS_MODULE, > > + .ops = { > > + .add = vmgenid_acpi_add, > > + .notify = vmgenid_acpi_notify, > > + } > > +}; > > + > > +static int __init vmgenid_init(void) > > +{ > > + return acpi_bus_register_driver(&acpi_driver); > > +} > > + > > +static void __exit vmgenid_exit(void) > > +{ > > + acpi_bus_unregister_driver(&acpi_driver); > > +} > > + > > +module_init(vmgenid_init); > > +module_exit(vmgenid_exit); > > Nit, you could use module_acpi_driver() to make this even smaller if you > want to. Nice! Will do. Jason