On Tue, 15 Feb 2022 12:09:53 +0100 Steffen Eiden <seiden@xxxxxxxxxxxxx> wrote: [...] > What about using the smp wrapper 'smp_sigp(idx, SIGP_RESTART, 0, NULL)' > here as well? [...] > With my nits fixed: maybe I should add a comment explaining why I did not use the smp_ variants. the reason is that the smp_ variants check the validity of the CPU index. but in those places, we have already checked (directly or indirectly) that the index is valid, so I save one useless check. on the other hand, I don't know if it makes sense to optimize for that, since it's not a hot path, and one extra check will not kill the performance. > > Reviewed-by: Steffen Eiden <seiden@xxxxxxxxxxxxx>
