Re: [PATCH v3 17/30] KVM: s390: pci: enable host forwarding of Adapter Event Notifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/14/22 7:59 AM, Pierre Morel wrote:


On 2/4/22 22:15, Matthew Rosato wrote:
...
+static void aen_process_gait(u8 isc)
+{
+    bool found = false, first = true;
+    union zpci_sic_iib iib = {{0}};
+    unsigned long si, flags;
+
+    spin_lock_irqsave(&aift->gait_lock, flags);
+
+    if (!aift->gait) {
+        spin_unlock_irqrestore(&aift->gait_lock, flags);
+        return;
+    }
+
+    for (si = 0;;) {
+        /* Scan adapter summary indicator bit vector */
+        si = airq_iv_scan(aift->sbv, si, airq_iv_end(aift->sbv));
+        if (si == -1UL) {
+            if (first || found) {
+                /* Reenable interrupts. */
+                if (zpci_set_irq_ctrl(SIC_IRQ_MODE_SINGLE, isc,
+                              &iib))
+                    break;

I thought we agreed that the test is not useful here.

Oops, you are correct -- it looks like I simply failed to apply any of your suggestions from that particular email, must have marked it 'done' on accident -- sorry about that. I've gone ahead and made these changes already on my in-progress v4 branch. Thanks for pointing it out.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux