Re: [PATCH 09/12] KVM: MMU: look for a cached PGD when going from 32-bit to 64-bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 09/12] KVM: MMU: look for a cached PGD when going from 32-bit to 64-bit
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Fri, 11 Feb 2022 11:09:01 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, vkuznets@xxxxxxxxxx, mlevitsk@xxxxxxxxxx, dmatlack@xxxxxxxxxx
In-reply-to: <YgW99wRxczsAJ0jv@google.com>
References: <20220209170020.1775368-1-pbonzini@redhat.com> <20220209170020.1775368-10-pbonzini@redhat.com> <YgW8ySdRSWjPvOQx@google.com> <YgW99wRxczsAJ0jv@google.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 2/11/22 02:37, Sean Christopherson wrote:

	if (VALID_PAGE(mmu->root.hpa) && mmu->root.hpa == __pa(mmu->pae_root))

Gah, that's wrong too, it will allow the pml4_root case.*sigh*   I'm fine punting
this until the special roots are less special, pml5_root is completely broken
anyways.


Ok, I'll look at your comments on Jiangshan's series.

Paolo

References:
- [PATCH 00/12] KVM: MMU: do not unload MMU roots on all role changes
  - From: Paolo Bonzini
- [PATCH 09/12] KVM: MMU: look for a cached PGD when going from 32-bit to 64-bit
  - From: Paolo Bonzini
- Re: [PATCH 09/12] KVM: MMU: look for a cached PGD when going from 32-bit to 64-bit
  - From: Sean Christopherson
- Re: [PATCH 09/12] KVM: MMU: look for a cached PGD when going from 32-bit to 64-bit
  - From: Sean Christopherson

Prev by Date: Re: [PATCH 06/12] KVM: MMU: rename kvm_mmu_reload
Next by Date: [PATCH 2/3] KVM: SVM: set IRR in svm_deliver_interrupt
Previous by thread: Re: [PATCH 09/12] KVM: MMU: look for a cached PGD when going from 32-bit to 64-bit
Next by thread: Re: [PATCH 09/12] KVM: MMU: look for a cached PGD when going from 32-bit to 64-bit
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]