>-----Original Message----- >From: Sean Christopherson <seanjc@xxxxxxxxxx> >Sent: Friday, February 11, 2022 12:31 AM >To: Duan, Zhenzhong <zhenzhong.duan@xxxxxxxxx> >Cc: kvm@xxxxxxxxxxxxxxx; pbonzini@xxxxxxxxxx >Subject: Re: [PATCH] x86 UEFI: Fix broken build for UEFI > >On Thu, Feb 10, 2022, Zhenzhong Duan wrote: >> UEFI loads EFI applications to dynamic runtime addresses, so it >> requires all applications to be compiled as PIC (position independent code). >> >> The new introduced single-step #DB tests series bring some compile >> time absolute address, fixed it with RIP relative address. >> >> Fixes: 9734b4236294 ("x86/debug: Add framework for single-step #DB >> tests") >> Fixes: 6bfb9572ec04 ("x86/debug: Test IN instead of RDMSR for >> single-step #DB emulation test") >> Fixes: bc0dd8bdc627 ("x86/debug: Add single-step #DB + STI/MOVSS >> blocking tests") >> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxx> >> --- > >Hrm. It would be nice if we could enabled -fPIC by default for tests that >support it, having to compile twice is going to be annoying... Agree it's annoying, but enable -fPIC for non-UEFI build may not help find this build error, because the error happen in link stage to generate xxx.so, while non-UEFI build will not generate xxx.so. Thanks Zhenzhong